-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: workerIdleMemoryLimit avoids runInBand unless explicitly set #13171
Conversation
if (workerIdleMemoryLimit) { | ||
console.warn( | ||
'workerIdleMemoryLimit does not work in combination with detectOpenHandles', | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to validate flags inside jest-cli
. Like this one:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah.. Will not work if workerIdleMemoryLimit
is set in config file.
@mrazauskas I think this is my preferred solution to the problem. I would appreciate it if we could get it (or #13168) merged and released, I've found a situation where I'm now struggling with the inability to run a worker with linear tests. |
This approach looks better for my eye. One thing which bother me is options validation which now lives in Also note that Simen is the maintainer who is merging PRs. I am just writing comments here and there (; |
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
#13168 (comment)