Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: workerIdleMemoryLimit avoids runInBand unless explicitly set #13171

Closed
wants to merge 5 commits into from

Conversation

phawxby
Copy link
Contributor

@phawxby phawxby commented Aug 25, 2022

Comment on lines +26 to +30
if (workerIdleMemoryLimit) {
console.warn(
'workerIdleMemoryLimit does not work in combination with detectOpenHandles',
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah.. Will not work if workerIdleMemoryLimit is set in config file.

@phawxby
Copy link
Contributor Author

phawxby commented Aug 31, 2022

@mrazauskas I think this is my preferred solution to the problem. I would appreciate it if we could get it (or #13168) merged and released, I've found a situation where I'm now struggling with the inability to run a worker with linear tests.

@mrazauskas
Copy link
Contributor

This approach looks better for my eye. One thing which bother me is options validation which now lives in jest-core. I think this should be moved somehow to jest-config. From the perspective of longer term maintenance this would be better idea. Perhaps?

Also note that Simen is the maintainer who is merging PRs. I am just writing comments here and there (;

@github-actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Nov 30, 2022
@github-actions
Copy link

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants